fix: Address most compile warnings#3858
Open
jcs090218 wants to merge 3 commits intoclojure-emacs:masterfrom
Open
fix: Address most compile warnings#3858jcs090218 wants to merge 3 commits intoclojure-emacs:masterfrom
jcs090218 wants to merge 3 commits intoclojure-emacs:masterfrom
Conversation
Member
|
Seems that some tests are failing in the CI. |
jcs090218
force-pushed
the
fix/warnings
branch
from
525d306 to
ccaa44b
Compare
Contributor
Author
|
The warnings aren’t fully addressed, but it’s a good start for now. 🤔 |
bbatsov
reviewed
Feb 6, 2026
| (defun cider--tooling-file-p (file-name) | ||
| "Return t if FILE-NAME is not a 'real' source file. | ||
| Currently, only check if the relative file name starts with 'form-init' | ||
| "Return t if FILE-NAME is not a `real' source file. |
Member
There was a problem hiding this comment.
I think it's better not to have quotes here at all.
bbatsov
reviewed
Feb 6, 2026
|
|
||
| (defun cider-docview-wrap-text (buffer) | ||
| "For text in BUFFER not propertized as 'block', apply line wrap." | ||
| "For text in BUFFER not propertized as `block', apply line wrap." |
Member
There was a problem hiding this comment.
Better remove the quotes here IMO.
bbatsov
reviewed
Feb 6, 2026
| 'qualified ;=> Vars are fully-qualified in the expansion | ||
| 'none ;=> Vars are displayed without namespace qualification | ||
| 'tidy ;=> Vars that are :refer-ed or defined in the current namespace are | ||
| `qualified ;=> Vars are fully-qualified in the expansion |
Member
There was a problem hiding this comment.
Why the use of different quotes here?
bbatsov
reviewed
Feb 6, 2026
| As it stands Emacs fires these events on <mouse-8> and <mouse-9> on 'x' and | ||
| 'w32'systems while on macOS it presents them on <mouse-4> and <mouse-5>.") | ||
| As it stands Emacs fires these events on <mouse-8> and <mouse-9> on `x' and | ||
| `w32'systems while on macOS it presents them on <mouse-4> and <mouse-5>.") |
Member
There was a problem hiding this comment.
Probably we can remove the quotes here completely, as the proposed quoting definitely seems incorrect given it was referring to the value of window-system.
bbatsov
reviewed
Feb 6, 2026
|
|
||
| As it stands Emacs fires these events on <mouse-8> and <mouse-9> on 'x' and | ||
| 'w32'systems while on macOS it presents them on <mouse-4> and <mouse-5>.") | ||
| As it stands Emacs fires these events on <mouse-8> and <mouse-9> on `x' and |
Member
There was a problem hiding this comment.
I'd drop the quotes and make X uppercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix most compile warnings.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.